Skip to content

[WIP] Add OCP 4.20 in rhads-config #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] Add OCP 4.20 in rhads-config #171

wants to merge 1 commit into from

Conversation

@jkopriva
Copy link
Collaborator

@jkopriva jkopriva commented Oct 6, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Tests
    • Updated integration tests to validate compatibility with OpenShift Container Platform (OCP) 4.20.
  • Chores
    • Updated test configuration to reflect OCP 4.20, keeping test environments aligned with the current platform version.

@jkopriva jkopriva requested a review from xinredhat as a code owner October 6, 2025 06:56
@coderabbitai
Copy link

coderabbitai bot commented Oct 6, 2025 •
edited
Loading

Walkthrough

Updated the OCP version value in integration-tests/config/rhads-config from 4.19 to 4.20. No other keys, logic, or control flow were modified.

Changes

Cohort / File(s) Summary
Config: OCP version bump
integration-tests/config/rhads-config		 Increment OCP value 4.19 → 4.20; no structural or logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Areas to spot-check: the updated config file for formatting/serialization issues and any test harnesses or CI job definitions that parse this value.
  • Consider running a quick E2E smoke to verify tests still target the expected OCP stream.

Possibly related PRs

Suggested reviewers

  • xinredhat
  • prietyc123

Provide constructive feedback focused on testing reliability, security, and maintainability for this TSSC E2E testing framework:

  • Add or update a lightweight validation/smoke test that asserts the config OCP version is within supported ranges before running full E2E suites.
  • Ensure downstream consumers parse the value robustly (avoid brittle string-matching) and handle unknown/unsupported versions gracefully.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically identifies the main change: adding OCP 4.20 support to rhads-config, which directly matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ee80798 and 281a20a.

📒 Files selected for processing (1)
  • integration-tests/config/rhads-config (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Red Hat Konflux / tssc-test-on-pull-request
🔇 Additional comments (1)
integration-tests/config/rhads-config (1)

1-1: Verify the pipeline failure root cause independently of the OCP 4.20 version availability.

OCP 4.20 is officially released and generally available, so the upgrade to this version is supported. The codebase search found no other hardcoded OCP version references that require updating.

However, the failed PipelineRun e2e-4.20-82r9m should still be investigated to determine whether the failure stems from test environment configuration, missing dependencies, incompatible settings, or other factors unrelated to OCP 4.20 availability. Review the test failure logs to confirm the issue is resolved or to identify the actual blocker before merging.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jkopriva jkopriva force-pushed the ocp-4.20 branch 2 times, most recently from a38614d to ee80798 Compare November 13, 2025 08:06
@konflux-ci-qe-bot
Copy link

konflux-ci-qe-bot commented Nov 18, 2025

@jkopriva: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
e2e-4.20-nvphb Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.20-nvphb

Test results analysis

<not enabled>

OCI Artifact Browser URL

<not enabled>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xinredhat xinredhat Awaiting requested review from xinredhat xinredhat is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

configuration testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jkopriva @konflux-ci-qe-bot